refactor(ast): Make ast enum non_exhaustive

[quininer]

Description:

This is the split of #11100 . Since we need to add unknown variants to the ast enum, this requires a lot of code changes to handle non-exhaustive match. I'm doing this in a separate PR for review.

BREAKING CHANGE:

Related issue (if exists):

[changeset-bot]

⚠️ No Changeset found

Latest commit: 9ee1a15

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[kdy1]

Do you think this should go into the main branch?
Can you change the target to ‘dev/rust’?

[quininer]

Sure, I can change it.

[codspeed-hq]

CodSpeed Performance Report

Merging #11115 will not alter performance

_{Comparing quininer:r/ast-non-exhaustive (9ee1a15) with main (66428a2)}

Summary

✅ 140 untouched

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	copyfiles@​2.4.1
	webpack-cli@​3.3.12
	webpack-dev-server@​3.11.3
	webpack@​4.47.0

View full report

[socket-security]

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert  (click "▶" to expand/collapse)
Warn		[email protected] has a Critical CVE. CVE: GHSA-fjxv-7rqg-78g4 form-data uses unsafe random function in form-data for choosing boundary (CRITICAL) Affected versions: < 2.5.4; >= 3.0.0 < 3.0.4; >= 4.0.0 < 4.0.4 Patched version: 2.5.4 From: ? → npm/[email protected] ℹ Read more on: This package | This alert | What is a critical CVE? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected]. Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Warn		[email protected] has Obfuscated code. Confidence: 0.96 Location: Package overview From: ? → npm/[email protected] → npm/[email protected] ℹ Read more on: This package | This alert | What is obfuscated code? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected]. Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

[Copilot]

Pull Request Overview

This PR implements the first step of adding unknown variants to AST enums by making all AST enums non_exhaustive. The changes enable the introduction of unknown variants in a future PR while ensuring that match statements are properly handled.

• Adds #[cfg(swc_ast_unknown)] conditional branches to handle future unknown variants
• Updates the visitor code generator to conditionally generate fallback arms for swc_ecma_ast
• Makes AST enums non-exhaustive except for specific ones (HTML, XML, regexp) that opt out

Reviewed Changes

Copilot reviewed 185 out of 186 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tools/generate-code/src/main.rs	Updates visitor generator to accept string parameter and detect swc_ecma_ast
tools/generate-code/src/generators/visitor.rs	Conditionally generates fallback arms for unknown variants in match statements
crates//src/.rs	Adds #[cfg(swc_ast_unknown)] fallback branches to existing match statements
crates/*/Cargo.toml	Adds lint configuration to recognize the swc_ast_unknown cfg
crates/swc_*_ast/src/base.rs	Adds no_unknown attribute to specific AST enums that shouldn't be non-exhaustive

Comments suppressed due to low confidence (2)

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[quininer]

I've switched to using a cfg flag instead of a feature to handle unknown variants, which makes it easier to ensure consistent handle.

Also, since all changes are behind the swc_ast_unknown cfg flag, it's not a breaking change. I think it can be safely merged into main branch.

[quininer]

I only added transforms ci since that covers most of sublibrary and is the primary use case for plugin.

[quininer]

I've ignored unknown in some places. there's no particular reason for this, maybe panick would be better.

[kdy1]

This is a breaking chnage regardless

[kdy1]

Addition of this means ast_node crate has a breaking change