Open
Conversation
Author
|
timon-schelling
requested changes
Mar 6, 2026
Collaborator
timon-schelling
left a comment
timon-schelling
left a comment
There was a problem hiding this comment.
Otherwise this look promising
| _: impl Ctx, | ||
| #[implementations(Table<Graphic>, Table<Vector>, Table<Raster<CPU>>, Table<Color>, Table<GradientStops>)] instance: Table<I>, | ||
| start_angle: Angle, | ||
| end_angle: Angle, |
Collaborator
There was a problem hiding this comment.
I think this should be a start and span/offset angle, and that angle should have not hard limits of -180/180.
| #[repr(C)] | ||
| #[derive(Debug, Clone, Copy, Default, PartialEq, Eq, serde::Serialize, serde::Deserialize, Hash, DynAny, specta::Type, node_macro::ChoiceType)] | ||
| #[widget(Radio)] | ||
| pub enum RepeatSpacing { |
Collaborator
There was a problem hiding this comment.
order should be like in the issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1
Added RepeatSpacing (Span/Pitch/Envelope/Gap) and AngularSpacing (Span/Pitch) choice enums.
Updated repeat to compute translation spacing based on the selected method, using the instance bounding box width along the direction for Envelope/Gap. Also avoids the count=1 divide-by-zero edge case.
Updated circular_repeat to take start_angle, end_angle, and spacing. In Span mode, it distributes from start to end. In Pitch mode, end_angle is interpreted as the pitch (0 defaults to full-circle spacing).
Updated tests to pass the new parameters.