Skip to content

Conversation

@nspassov
Copy link
Contributor

@nspassov nspassov commented Jul 29, 2025

  • Use UTType to determine content type for .file() handlers
  • Adjust minimum target versions
  • Update unit tests

@nspassov nspassov force-pushed the feature/uttype-for-content-type branch from e7496fd to a7c1cda Compare July 29, 2025 10:35
@codecov
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

❌ Patch coverage is 69.56522% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.17%. Comparing base (67105c3) to head (1d52ca6).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
FlyingFox/Sources/Handlers/FileHTTPHandler.swift 69.56% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
- Coverage   94.56%   94.17%   -0.39%     
==========================================
  Files          62       62              
  Lines        4119     4138      +19     
==========================================
+ Hits         3895     3897       +2     
- Misses        224      241      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@swhitty swhitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just a few small changes to get the builds to pass for Swift 5

Package.swift Outdated
name: "FlyingFox",
platforms: [
.macOS(.v10_15), .iOS(.v13), .tvOS(.v13), .watchOS(.v8)
.macOS(.v11), .iOS(.v13), .tvOS(.v13), .watchOS(.v8)
Copy link
Owner

@swhitty swhitty Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this branch without this v11 change and all tests passed so we can remove this.

Then we can merge 🙏🏻

@swhitty
Copy link
Owner

swhitty commented Aug 1, 2025

Thanks!

@swhitty swhitty merged commit 6f06029 into swhitty:main Aug 1, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants