Fix process handle leak on Windows #5270
Open
+18
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
I see the process tests are skipped on windows for a reason that as since been fixed... going to see If I can get then going again... |
daveinglis
force-pushed
the
fix_handle_leak
branch
3 times, most recently
from
eb655ca to
a79623a
Compare
|
@swift-ci test |
|
@swift-ci test windows |
daveinglis
force-pushed
the
fix_handle_leak
branch
2 times, most recently
from
ca97bc0 to
b3edb46
Compare
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci test window |
|
@swift-ci test windows |
daveinglis
force-pushed
the
fix_handle_leak
branch
from
b3edb46 to
b8ad565
Compare
|
@swift-ci test |
|
@swift-ci test windows |
daveinglis
force-pushed
the
fix_handle_leak
branch
from
b8ad565 to
9090ee9
Compare
|
@swift-ci test |
|
@swift-ci test windows |
weissi
reviewed
Oct 3, 2025
- Add a missing CloseHandle as part of the process termination handling - Enable Process tests on Windows
daveinglis
force-pushed
the
fix_handle_leak
branch
from
9090ee9 to
d6447a6
Compare
|
@swift-ci test |
jakepetroules
approved these changes
Oct 6, 2025
There was a problem hiding this comment.
This looks good to me; please get @iCharlesHu or @parkera to review as well.
|
@swift-ci test Windows |
1 similar comment
|
@swift-ci test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.