Skip to content

fixed #5285 fatalError when connection was lost immediately after sending r… #5286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jollyjinx wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fixed #5285 fatalError when connection was lost immediately after sending r… #5286

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bfffb2
fixed fatalError when connection was lost immediately after sending r…
jollyjinx Nov 9, 2025
4bff09c
fixed spacing
jollyjinx Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Sources/FoundationNetworking/URLSession/NativeProtocol.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,11 @@ internal class _NativeProtocol: URLProtocol, _EasyHandleDelegate {
}

guard let response = ts.response else {
fatalError("Transfer completed, but there's no response.")
internalState = .transferFailed
let error = NSError(domain: NSURLErrorDomain, code: NSURLErrorNetworkConnectionLost,
userInfo: [NSLocalizedDescriptionKey: "The network connection was lost."])
Copy link
Contributor

@guoye-zhang guoye-zhang Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the message in the error description?

Suggested change
userInfo: [NSLocalizedDescriptionKey: "The network connection was lost."])
userInfo: [NSLocalizedDescriptionKey: "Transfer completed, but there's no response."])

failWith(error: error, request: request)
return
}
internalState = .transferCompleted(response: response, bodyDataDrain: ts.bodyDataDrain)
let action = completionAction(forCompletedRequest: request, response: response)
Expand Down