Fix LocalFileSystem.move() to not follow symlinks when checking source existence #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e existence The move() method was using exists(sourcePath) which follows symlinks by default. This caused failures when moving a symlink whose target had already been moved, because it would try to follow the symlink to validate the target exists. Now uses exists(sourcePath, followSymlink: false) to check if the symlink itself exists, allowing symlinks to be moved even if their targets have been relocated. This fixes an issue where extracting package archives with symlinks could fail if files were moved in alphabetical order and a target file was moved before its symlink. Added test testMoveSymlinkWithMovedTarget() to verify this behavior.
fortmarek
force-pushed
the
fix-symlink-move
branch
from
3d768ca to
a9f8fdf
Compare
pepicrft
approved these changes
Nov 24, 2025
owenv
approved these changes
Dec 1, 2025
Contributor
|
@swift-ci test |
Contributor
Author
|
Thanks for the review @owenv! The only test failing on Windows is: I don't see this test in the codebase and I don't see how it is related to the changes. Is it possible the failure is a flake? |
Member
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
move()method was usingexists(sourcePath)which follows symlinks by default. This caused failures when moving a symlink whose target had already been moved, because it would try to follow the symlink to validate the target exists.Now it uses
exists(sourcePath, followSymlink: false)to check if the symlink itself exists, allowing symlinks to be moved even if their targets have been relocated.This fixes an issue where extracting package archives with symlinks could fail if files were moved in alphabetical order and a target file was moved before its symlink as described in: swiftlang/swift-package-manager#9411