[Swiftify] Fix Package.swift #84834
Merged
[Swiftify] Fix Package.swift #84834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swift packages are normally in `Sources/<target-name>`, but SwiftifyImportMacro is in `Sources/SwiftMacros`, and SwiftifyImport is in `<root>/stdlib/public/core`, which is outside the package root. This sets the correct path for SwiftifyImportMacro, and creates a directory `Sources/PublicCorePortal` with a symlink to `SwiftifyImport.swift`. It also enables LifetimeDependence for SwiftifyImport. These changes are purely to provide information to SourceKit - this file isn't actually used by CMake.
|
@swift-ci please smoke test |
Xazax-hun
approved these changes
Oct 13, 2025
egorzhdan
approved these changes
Oct 13, 2025
| @@ -0,0 +1 @@ | |||
| ../../../../stdlib/public/core/SwiftifyImport.swift No newline at end of file | |||
There was a problem hiding this comment.
I wonder if this would work on Windows, given that symlinks are somewhat special there. Given that Package.swift isn't used in the actual build, I don't think that's a priority though.
There was a problem hiding this comment.
How do symlinks work on Windows?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out this Package.swift file was borked all along.
Swift packages are normally in
Sources/<target-name>, but SwiftifyImportMacro is inSources/SwiftMacros, and SwiftifyImport is in<root>/stdlib/public/core, which is outside the package root. This sets the correct path for SwiftifyImportMacro, and creates a directorySources/PublicCorePortalwith a symlink toSwiftifyImport.swift. It also enables LifetimeDependence for SwiftifyImport.These changes are purely to provide information to SourceKit - this file isn't actually used by CMake.