[IRGen] Use linkonce_odr hidden linkage for _swift_dead_method_stub #84836
+16
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
IRGen introduces the symbol _swift_dead_method_stub for dead vtable entries to point to. This symbol was given internal linkage, which would result in multiply-defined symbols when combined with Embedded Swift's use of aggressive CMO. Switch to linkonce_odr hidden linkage so multiple versions of this symbol can be coalesced by the linker (and dropped if not needed). Fixes rdar://162392119.
DougGregor
force-pushed
the
linkonce-odr-dead-method-stub
branch
from
4d9d1df to
5ed051a
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IRGen introduces the symbol _swift_dead_method_stub for dead vtable entries to point to. This symbol was given internal linkage, which would result in multiply-defined symbols when combined with Embedded Swift's use of aggressive CMO. Switch to linkonce_odr hidden linkage so multiple versions of this symbol can be coalesced by the linker (and dropped if not needed).
Fixes rdar://162392119.