Add logging getLLDBLibPath to better diagnose failures #1943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
requested review from
0xTim,
adam-fowler and
award999
as code owners
award999
reviewed
Nov 18, 2025
| ): Promise<Result<string>> { | ||
| let executable: string; | ||
| try { | ||
| executable = await toolchain.getLLDB(); |
Contributor
There was a problem hiding this comment.
while we're here, maybe a debug log of what was found
| logger?.error(`Failed to get LLDB library path for lldb on Windows, error: ${error}`); | ||
| return Result.makeFailure(undefined); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Can't seem to add comment to lines not in patch, but in findLibLLDB can we add debug logging for which folders we try to find it in, and debug result of await findLibLLDB(pathHint)
Contributor
There was a problem hiding this comment.
Also don't think it would be too verbose to log directory contents returned by readdir in findFileByPattern
Contributor
|
Some suggestions of how we could taker debug logging even further |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help diagnose the failure to find LLDB on Windows 6.2
Tasks