-
Notifications
You must be signed in to change notification settings - Fork 2
Factorize detection merge #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cleherny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review. It was sometimes difficult for my end of the week-fried brain to keep track of the changes, as some parts of the code were moved to other scripts, but I hope I didn't miss anything important. In any case, it looks good!
I made a couple of minor comments. At the same time, I also answered to your comments of PR #49.
I haven't looked in details at the data_augmentation part, so perhaps @acerioni could have a deeper look, along with all the changes of this PR.
I tested the quarry example and it works fine. I ran one test with the empty tiles and it seems fine. Have you fixed the issue of assigning empty tiles to another dataset?
No description provided.