Skip to content

Conversation

@hirasso
Copy link
Member

@hirasso hirasso commented Jun 7, 2025

Description

  • add unit tests via vitest
  • add e2e tests via playwright + astro fixtures
  • add test-related GitHub workflows
  • See package.json scripts
  • Currently doesn't do much – but maybe we first merge this one into next and implement actual tests in another PR?

Drive-By

  • remove scrl-related documentation from the readme that snuck back in

E2E test fixtures

npm run fixtures:dev

Currently, the fixtures look like this:

CleanShot 2025-06-07 at 21 37 28@2x

Checks

  • The PR is submitted to the next branch
  • The code was linted before pushing (npm run lint)
  • All tests are passing (npm run test)
  • New or updated tests are included

@hirasso hirasso mentioned this pull request Jun 7, 2025
Merged
13 tasks
@hirasso hirasso changed the title Add Tests Infrastructure Add Tests Jun 7, 2025
@github-actions
Copy link

github-actions bot commented Jun 7, 2025

Playwright test results

passed  3 passed

Details

stats  3 tests across 1 suite
duration  
commit  845e5a9

- fix the title
- add badges
@hirasso hirasso marked this pull request as ready for review June 7, 2025 19:45
@hirasso hirasso requested a review from daun June 7, 2025 19:47
@hirasso hirasso changed the title Add Tests Setup Tests Jun 7, 2025
@hirasso hirasso mentioned this pull request Jun 7, 2025
Copy link
Member

@daun daun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Happy to merge this now and tackle the actual tests separately:)

@hirasso hirasso merged commit b9d8412 into next Jun 7, 2025
2 checks passed
@hirasso hirasso deleted the add-tests branch June 7, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants