Skip to content

[LiveComponent] Support JSONResponse for LiveActions #2967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: 2.x
Choose a base branch
from
Open

[LiveComponent] Support JSONResponse for LiveActions #2967

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cffc046
LiveComponent: Prevent Error Rendering on JSON Response
xDeSwa Aug 1, 2025
2ba9b88
Support JSONResponse in LiveActions
xDeSwa Aug 6, 2025
bbadfbc
fix typos
xDeSwa Aug 6, 2025
f8988b5
fix doc rst
xDeSwa Aug 6, 2025
c34de94
fix doc rst v2
xDeSwa Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/LiveComponent/assets/dist/live_controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2014,7 +2014,7 @@ var Component = class {
const controls = { displayError: true };
this.valueStore.pushPendingPropsBackToDirty();
this.hooks.triggerHook("response:error", backendResponse, controls);
if (controls.displayError) {
if (controls.displayError && !headers.get("Content-Type")?.includes("application/json")) {
this.renderError(html);
}
this.backendRequest = null;
Expand Down
2 changes: 1 addition & 1 deletion src/LiveComponent/assets/src/Component/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ export default class Component {
this.valueStore.pushPendingPropsBackToDirty();
this.hooks.triggerHook('response:error', backendResponse, controls);

if (controls.displayError) {
if (controls.displayError && !headers.get('Content-Type')?.includes('application/json')) {
this.renderError(html);
}

Expand Down
Loading