Finnish translation added#82
Finnish translation added#82jremes-foss wants to merge 11 commits intosympy:sourcesfrom jremes-foss:finnish_translation
Conversation
There was a problem hiding this comment.
I think you forgot to commit the fi.po file.
There was a problem hiding this comment.
Thanks for notification, I'll add it now.
|
@pv, would you mind quickly reviewing the Finnish translation (to make sure it's high enough quality so that we can merge it)? It's just the |
fi/development.html
Outdated
There was a problem hiding this comment.
I would very much like to see 'patch' translated. For example, 'korjaustiedosto' (or sometimes just 'korjaus').
There was a problem hiding this comment.
Yes, I thought that. How ever, "korjaustiedosto" in general tends to mean (literally translated) "a bug fix file". Patches can be new features or code maintenance as well.
There was a problem hiding this comment.
But if this is a non-issue, I can translate the term directly.
|
Hi. As per request, I changed word "patch" to "korjaustiedosto" which is more accurate translation. |
|
Thanks @jksuom. Is there anything else? |
fi/development.html
Outdated
There was a problem hiding this comment.
Would it be possible to find some translations for 'pull request' and 'repository'?
There was a problem hiding this comment.
Sure, I'll translate these as soon as I can, probably tomorrow morning
Repository = säilytyspaikka? varasto? repositorio?
Pull request = vetopyyntö?
Most of the sources I've checked are using English terms directly and there are no standard translations for these. If you have any recommendations, please let me know.
|
Another possible translation for 'patch' could be 'muutostiedosto' (muutos = change). That would cover about everything, additions, deletions, and fixes. (Though patches often are thought of as fixes (korjaus = fix).) |
|
Most suggestions are now covered. Only issue is fi/features.html, line 146. This entry is not found in the .po file. |
i18n/fi.po
Outdated
There was a problem hiding this comment.
Here and elsewhere, note grammar for space before/after dash: Risch-Norman-heuristiikka, Planet Sympy -blogi
fi/features.html
Outdated
There was a problem hiding this comment.
I think something like "rajoittamattomat kokonaisluvut" could be a better description for these numbers (instead of "mielivaltaisen tarkat" as integers are always exact).
fi/features.html
Outdated
There was a problem hiding this comment.
Local logicians use the term "lause" in a rather strict sense to denote logical formulas with no free variables. They would use "kaava" (formula) for the general case. My personal favourite is "lauseke" (i.e. "Loogiset lausekkeet").
|
I think that was about all I could suggest. It looks good to me now. |
|
@pv and @jksuom thanks a lot for reviewing this! @NewMan101 let me know when this is ready to be merged. |
|
Ok, last issue has been fixed - I added the missing string to .po file. I think this can be merged now. |
|
Thanks! Don't you have to regenerate the files when the |
|
I think I did, but apparently I didn't. Thank you for notifying - I'll re-generate the pages and commit the changes. |
|
Ok, looks like the last change in |
|
I'll need to investigate why this happens. |
|
Looks like the http://stackoverflow.com/questions/7680021/how-to-add-a-new-string-to-a-po-file-w-a-po-editor |
|
I tried merging it with |
|
There is something dodgy here. "Permutation Groups" refers to line |
|
The question follows: Why "Permutation Groups" got translated but "Polyhedral, Rubik, Symmetric, ..." didn't? After all, they are both supposed to be on the same line. |
|
This might be an issue on other localizations as well. |
|
Sorry for the problems. Did you run |
|
I am fairly certain I did, but I can re-attempt that tomorrow morning. |
|
Still investigating the issue with that last problematic string. Is any of the languages fully translated and functional? |
4 participants
Finnish translation added to sympy.github.com site. All strings translated.
If there is anything else regarding this, please let me know.
Thank you.