- 
                Notifications
    You must be signed in to change notification settings 
- Fork 79
Fix race condition when pending Promise was resolved in other thread #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            alex-verve
  wants to merge
  3
  commits into
  syrusakbary:master
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
alex-verve:master
  
      
      
   
  
    
  
  
  
 
  
      
    base: master
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    1c918aa    to
    e4235ad      
    Compare
  
    Also latest version pytest-cov and pytest-asyncio are not compatible with latest pytest. https://travis-ci.org/github/syrusakbary/promise/jobs/708528307 Could not find a version that satisfies the requirement pytest>=5.4.3 (from promise==2.3) (from versions: 2.0.0, ......... 4.6.10, 4.6.11) https://travis-ci.org/github/syrusakbary/promise/jobs/708523881 E AttributeError: type object 'Function' has no attribute 'from_parent' https://travis-ci.org/github/syrusakbary/promise/jobs/708735234 pytest-cov 2.10.0 has requirement pytest>=4.6, but you'll have pytest 4.3.1 which is incompatible.
137b395    to
    e975419      
    Compare
  
    | There is at least one more race-condition in   | 
| Is there any update on this or any way to help out? This is a critical issue since we are using Promise for job scheduling in production, and every once in a while this error comes around and forces us to re-run | 
    
  jkimbo 
      added a commit
        to strawberry-graphql/strawberry
      that referenced
      this pull request
    
      Jan 8, 2021 
    
    
      
  
    
      
    
  
Also incorporate fix: syrusakbary/promise#89
    
  patrick91 
      pushed a commit
        to strawberry-graphql/strawberry
      that referenced
      this pull request
    
      Feb 8, 2021 
    
    
      
  
    
      
    
  
Also incorporate fix: syrusakbary/promise#89
    
  patrick91 
      pushed a commit
        to strawberry-graphql/strawberry
      that referenced
      this pull request
    
      Apr 1, 2021 
    
    
      
  
    
      
    
  
Also incorporate fix: syrusakbary/promise#89
    
  jkimbo 
      added a commit
        to strawberry-graphql/strawberry
      that referenced
      this pull request
    
      Jun 15, 2021 
    
    
      
  
    
      
    
  
Also incorporate fix: syrusakbary/promise#89
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
I had to pin pytest* deps to make tests working again (new versions of
pytest-covandpytest-asyncioare not supported by latest pytest version for pypy)Fixes #87
Test failure (without fix) - https://travis-ci.org/github/syrusakbary/promise/builds/708825617
Test passed here (with fix) - https://travis-ci.org/github/syrusakbary/promise/builds/708827378