Fix clint node in DTS by removing interrupt-controller property #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the device tree configuration by removing the interrupt-controller property from the clint node. The clint only handles timer and software interrupts, and should not be configured as an interrupt controller. Only the plic should be marked as an interrupt-controller as it manages external interrupts. This change resolves the following dtc warnings about missing proper configuration of interrupt handling: <stdin>:31.31-37.11: Warning (interrupt_provider): /soc@F0000000/clint@4300000: Missing #interrupt-cells in interrupt provider <stdin>:31.31-37.11: Warning (interrupt_provider): /soc@F0000000/clint@4300000: Missing #address-cells in interrupt provider
This comment was marked as duplicate.
This comment was marked as duplicate.
ChinYikMing
approved these changes
Sep 1, 2024
|
Thank @visitorckw for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the device tree configuration by removing the interrupt-controller property from the clint node. The clint only handles timer and software interrupts, and should not be configured as an interrupt controller. Only the plic should be marked as an interrupt-controller as it manages external interrupts.
This change resolves the following dtc warnings about missing proper configuration of interrupt handling:
:31.31-37.11: Warning (interrupt_provider): /soc@F0000000/clint@4300000: Missing #interrupt-cells in interrupt provider
:31.31-37.11: Warning (interrupt_provider): /soc@F0000000/clint@4300000: Missing #address-cells in interrupt provider