Enable ISIG control mode of termios after exit #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Dec 10, 2024
ChinYikMing
force-pushed
the
fix/termios-control-mode
branch
from
8439418 to
c3b6383
Compare
The ISIG control mode is disabled in capture_keyboard_input(), but it is not reset in reset_keyboard_input(). This inconsistency causes default keyboard signal malfunctions (e.g., SIGINT from CTRL+C) after exit. To fix this, the termios control flag is encapsulated in a macro, TERMIOS_C_CFLAG and used in both capture_keyboard_input() and reset_keyboard_input().
ChinYikMing
force-pushed
the
fix/termios-control-mode
branch
from
c3b6383 to
58598a8
Compare
|
Thank @ChinYikMing for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to reproduce?
Terminate the emulation via keyboard
CTRL + a + x.Run some shell interactive program (e.g., cat).
CTRL + c.The SIGINT cannot be caught and propagate to the
catprocess. Example output:This patch fix this issue.