Fix incremental build #57
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plugin was breaking Gradle's incremental build by setting task.outputs.upToDateWhen { false } which forced recompilation every time. This particularly affected the compileTestKotlin task.
Changes:
- Removed the upToDateWhen { false } logic that broke caching
- Simplified the compilation task configuration
- Ensured directory creation happens at the right time without affecting caching
This fix allows proper incremental builds to work, significantly improving build performance for projects using the inspektor plugin.
nataphonk
force-pushed
the
fix-incremental-build
branch
from
3809219 to
fe2f4ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incremental build caching issue
Problem
The plugin was breaking Gradle's incremental builds by forcing tasks to always recompile, significantly impacting build performance.
Solution
task.outputs.upToDateWhen { false }logic that prevented cachingUP-TO-DATEon subsequent buildsImpact
compileTestKotlinand other tasks now cache correctlyTesting
Tested locally - confirmed tasks are properly cached after the fix.