-
Notifications
You must be signed in to change notification settings - Fork 8
v2/logging: add support for network flow logs API #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5dc58f2
to
f470446
Compare
928e93e
to
b1aad5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this LGTM, I have a few further mainly documentation-related suggestions. Would love a second pair of eyeballs from @oxtoacart on the library API changes, too.
b1aad5d
to
9ce246e
Compare
980f0b5
to
9ce246e
Compare
494259d
to
563d85f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, just one question about validation.
563d85f
to
bc6dee0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for tackling a streaming version of this, I think that'll be valuable.
bc6dee0
to
9d46760
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few leftover suggestions at your option.
9d46760
to
8b00d5b
Compare
Adds support for the network flow logs API endpoint at /api/v2/tailnet/{tailnet}/logging/network. This endpoint returns network traffic flow data including virtual, subnet, exit, and physical traffic with packet/byte counts. Updates tailscale#41 Signed-off-by: rajsinghtech <[email protected]>
8b00d5b
to
588a989
Compare
Adds support for the network flow logs API endpoint at /api/v2/tailnet/{tailnet}/logging/network. This endpoint returns network traffic flow data including virtual, subnet, exit, and physical traffic with packet/byte counts.
Updates #41