tailscale/resource_logstream_configuration: support UploadPeriodMinut… #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxtoacart
commented
Mar 4, 2025
| testacc: | ||
| TF_ACC=1 go test $(TEST) -v $(TESTARGS) -timeout 120m | ||
|
|
||
| testacc_local: |
There was a problem hiding this comment.
Drive-by, makes local acceptance testing easier.
|
Successful acceptance test run - https://github.com/tailscale/corp/actions/runs/13658279162/job/38182972188 |
oxtoacart
commented
Mar 4, 2025
| "upload_period_minutes": { | ||
| Type: schema.TypeInt, | ||
| Description: "The number of minutes to wait in between uploading new logs. If the quantity of logs does not fit within a single upload, multiple uploads will be made. Defaults to 1.", | ||
| Default: 1, |
There was a problem hiding this comment.
@mpminardi Will specifying defaults here (or in the API implementation) cause spurious plan updates for existing configurations that don't specify these parameters?
oxtoacart
force-pushed
the
percy/corp26860
branch
3 times, most recently
from
28021d7 to
12549a4
Compare
oxtoacart
force-pushed
the
percy/corp26860
branch
from
12549a4 to
d59e7ee
Compare
oxtoacart
commented
Mar 4, 2025
| } | ||
| ``` | ||
|
|
||
| Remember to run `make build` to build the provider and pick up your local changes. |
There was a problem hiding this comment.
Drive-by, as I forgot to do this while I was testing :)
oxtoacart
force-pushed
the
percy/corp26860
branch
from
d59e7ee to
2d273a0
Compare
mpminardi
approved these changes
Mar 5, 2025
oxtoacart
force-pushed
the
percy/corp26860
branch
from
2d273a0 to
c21286d
Compare
…es and CompressionFormat parameters Updates tailscale/corp#26860 Updates tailscale/corp#26867 Signed-off-by: Percy Wegmann <[email protected]>
oxtoacart
force-pushed
the
percy/corp26860
branch
from
c21286d to
8cfe8c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…es and CompressionFormat parameters
Updates tailscale/corp#26860
Depends on tailscale/tailscale-client-go-v2#14