Added image gradients to wrapper. #163
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| throw new ArgumentNullException(nameof(image)); | ||
|
|
||
| if (gradient == null) | ||
| throw new ArgumentNullException(nameof(image)); |
There was a problem hiding this comment.
And
image.ThrowIfDisposed();
graduent.ThrowIfDisposed();
There was a problem hiding this comment.
And, you created feature branch but it does not derive from develop branch.
Why don't you use gitflow?
By chance, does github PR force to create branch from master?
There was a problem hiding this comment.
Thanks for the feedback. Done.
Regarding the branch, I don't understand?
Should I branch from development instead of master?
There was a problem hiding this comment.
Should I branch from development instead of master?
Yes. I adopt gitflow development model.
I'm very sorry for the inconvenience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.