Skip to content

chore: publish 1.x NPM packages with the v1 tag #11188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 15, 2024
Merged

chore: publish 1.x NPM packages with the v1 tag #11188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa01a1a
chore: publish 1.x NPM packages with the v1 tag
lucasfernog Oct 1, 2024
2fb1565
Merge branch '1.x' into chore/v1-tag
amrbashir Oct 15, 2024
ebbe017
remove change file, not needed
amrbashir Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .changes/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@
"pipe": true
},
{
"command": "yarn publish --access public --loglevel silly",
"command": "yarn publish --access public --loglevel silly --tag v1",
"dryRunCommand": "npm publish --dry-run --access public",
"pipe": true
},
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-cli-js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ jobs:
- name: Publish
run: |
echo "//registry.npmjs.org/:_authToken=$NPM_TOKEN" >> ~/.npmrc
npm publish
npm publish --tag v1
Copy link
Member

@amrbashir amrbashir Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really need a tag? Isn't this the same as just using @1 ?

For me, tags have always been just a way to change between stable and next (alpha, beta or rc)

Copy link
Member Author

@lucasfernog lucasfernog Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm you do have a point, i guess we just need to change docs then cc @tweidinger

Copy link
Member Author

@lucasfernog lucasfernog Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this works tauri-apps/tauri-docs#2773

env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.ORG_NPM_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion tooling/api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"scripts": {
"build": "rollup -c --configPlugin typescript",
"npm-pack": "yarn build && cd ./dist && npm pack",
"npm-publish": "yarn build && cd ./dist && yarn publish --access public --loglevel silly",
"npm-publish": "yarn build && cd ./dist && yarn publish --access public --loglevel silly --tag v1",
"ts:check": "tsc -noEmit",
"lint": "eslint --ext ts \"./src/**/*.ts\"",
"lint:fix": "eslint --fix --ext ts \"./src/**/*.ts\"",
Expand Down
Loading