Issue #140, part 2 - Fix issue where input would error out if selected value went missing#157
Open
joeyparis wants to merge 2 commits intotbleckert:mainfrom
Open
Issue #140, part 2 - Fix issue where input would error out if selected value went missing#157joeyparis wants to merge 2 commits intotbleckert:mainfrom
joeyparis wants to merge 2 commits intotbleckert:mainfrom
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tbleckert/react-select-search/BEzzoagNSuJG8Zciko3rQmhnnEWX |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very similar issue to #140 (fixed by #141), but later in the life cycle.
Scenario:
As @tbleckert mentioned here, this is more of a patch than it is an actual fix. But still probably worth merging in for the time being, and then keeping in mind for the real solution with
getOptionwhen used withgetDisplayValueandisSelected.