Meta: switch publish-biblio to trusted publishing #3706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The rendered spec for this PR is available at https://tc39.es/ecma262/pr/3706. |
michaelficarra
approved these changes
Oct 16, 2025
bakkot
added
the
ready to merge
ljharb
requested changes
Oct 17, 2025
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
OIDC and trusted publishing have severe security issues, even worse than our current setup. We should not do this.
Member
Author
|
I'm open to hearing your case for that, but I don't think that's true. Why do you believe that to be so? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing token-based publishing will stop working soon. Anyway, best not to have to store a secrets in settings. See npm docs on trusted publishing. I already set up the package to trust the publish-biblio.yml workflow.