improvement: add claims to JWT by Context #1049
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows adding claims to magic links by passing them in context Documentation is missing because I think the Ash Team will have opinions about this change. After finding the correct solution that works for everyone, I will add the Documentation.
zachdaniel
reviewed
Jul 30, 2025
| when is_struct(strategy, __MODULE__) do | ||
| context_map = Map.from_struct(context) | ||
| source_context = Map.get(context_map, :source_context, %{}) | ||
| context_claims = Map.get(source_context, :claims, %{}) |
Collaborator
There was a problem hiding this comment.
Hm...I think we'd have to stew on this one. Likely if we do this the name here would need to be much more specific though, like :magic_link_token_claims for example.
@jimsynz thoughts?
Collaborator
There was a problem hiding this comment.
Well if we're doing to do this I think we should make it consistent for any action that generates a token (ie modify GenerateTokenChange to have the same behaviour).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows adding claims to magic links by passing them in context
Documentation is missing because I think the Ash Team will have opinions about this change.
After finding the correct solution that works for everyone, I will add the Documentation.