Update NGSI support to use ES6 syntax.#850
Merged
fgalan merged 8 commits intotelefonicaid:feature/842_ngsi_ldfrom Mar 11, 2020
Merged
Update NGSI support to use ES6 syntax.#850fgalan merged 8 commits intotelefonicaid:feature/842_ngsi_ldfrom
fgalan merged 8 commits intotelefonicaid:feature/842_ngsi_ldfrom
Conversation
Closed
Member
|
Once PR #848 has been merged, I have change the base of this PR to feature/842_ngsi_ld Please upgrade jason-fox:feature-ngsi-ld-es6 with telefonicaid:feature/842_ngsi_ld so this PR gets ready to merge (note a couple of files are conflicting). |
…ngsi-ld-es6 # Conflicts: # lib/services/ngsi/ngsiService.js # lib/services/northBound/contextServerUtils.js
Contributor
Author
|
Merged, updated and removed |
fgalan
reviewed
Mar 11, 2020
| @@ -37,11 +35,6 @@ function readExampleFile(name, raw) { | |||
| console.error(JSON.stringify(e)); | |||
Member
There was a problem hiding this comment.
Should this one also be removed? Or is pre-existing to your work on NGSI-LD?
(Maybe a grep for console. in all the code base could help to find additional cases)
Contributor
Author
There was a problem hiding this comment.
Nope - that is a deliberate console output - see the previous line. It was part of the output of #832
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #841 (comment)
This is a limited PR updates the files within
/services/devices/,services/ngsi/andservices\northBoundto properly useletandconst. When processed it would reduce the scope of #831It only contains automated code updates at the moment. The PR could also be amended to correctly rename the
northBoundsubdirectory tonorthPortsee: #645The assumption here is that since none of the other outstanding PRs are amending the NGSI interactions, this would be an opportunity to modernize at least part of the code base.