-
Notifications
You must be signed in to change notification settings - Fork 277
Updates Poller Autoscaler Content #3958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📖 Docs PR preview links
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Looking good, just a couple small suggestions
docs/develop/worker-performance.mdx
Outdated
|
|
||
| Task Pollers enable efficient load balancing across multiple Worker processes. | ||
| The number of Task Pollers can be configured using `WorkerOptions` when creating a new Worker instance. | ||
| Temporal SDKs implement support for *Automated Poller Tuning*, which dynamically adjusts the number of pollers in use to maximize throughput for a given number of workers and the size of the task backlog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's call this Poller Autoscaling to match the behavior names in the code
docs/develop/worker-performance.mdx
Outdated
| Task Pollers enable efficient load balancing across multiple Worker processes. | ||
| The number of Task Pollers can be configured using `WorkerOptions` when creating a new Worker instance. | ||
| Temporal SDKs implement support for *Automated Poller Tuning*, which dynamically adjusts the number of pollers in use to maximize throughput for a given number of workers and the size of the task backlog. | ||
| Temporal recommends using Automated Poller Tuning for the majority of use cases, as manually setting this value too high or too low for your workload will result in decreased performance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Temporal recommends using Automated Poller Tuning for the majority of use cases, as manually setting this value too high or too low for your workload will result in decreased performance. | |
| Temporal recommends using Automated Poller Tuning for the majority of use cases, as manually setting the number of pollers too high or too low for your workload will result in decreased performance. |
docs/develop/worker-performance.mdx
Outdated
| GO SDK: https://pkg.go.dev/go.temporal.io/sdk/worker#PollerBehaviorAutoscalingOptions | ||
| ```go | ||
| w := worker.New(c, "my-task-queue", worker.Options{ | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can get rid of the extra empty lines between assignments in all these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
docs/develop/worker-performance.mdx
Outdated
| Pollers create long-polling connections to the Temporal Service, allowing the service to dispatch Tasks to Workers. | ||
| When a Task Poller receives a Task, it delivers to the appropriate Executor Slot for processing. | ||
| A Worker's **Task Pollers** play a crucial role in the Temporal architecture by efficiently ingesting work to Workers to support scalable, resilient Workflow Execution. | ||
| Pollers create long-polling connections to the Temporal Service and actively poll a Task Queue for Tasks to process. When a Task Poller receives a Task, it delivers to the appropriate Executor Slot for processing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Pollers create long-polling connections to the Temporal Service and actively poll a Task Queue for Tasks to process. When a Task Poller receives a Task, it delivers to the appropriate Executor Slot for processing. | |
| Pollers create long-polling connections to the Temporal Service and actively poll a Task Queue for Tasks to process. When a Task Poller receives a Task, it delivers the Task to the appropriate Executor Slot for processing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch.
Adds sdktabs import statements that will (hopefully) fix the broken build
Attempt to fix markdown-fu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good! Just some general docs clean up and tweaks.
docs/develop/worker-performance.mdx
Outdated
| Pollers create long-polling connections to the Temporal Service, allowing the service to dispatch Tasks to Workers. | ||
| When a Task Poller receives a Task, it delivers to the appropriate Executor Slot for processing. | ||
| A Worker's **Task Pollers** play a crucial role in the Temporal architecture by efficiently ingesting work to Workers to support scalable, resilient Workflow Execution. | ||
| Pollers create long-polling connections to the Temporal Service and actively poll a Task Queue for Tasks to process. When a Task Poller receives a Task, it delivers to the appropriate Executor Slot for processing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Pollers create long-polling connections to the Temporal Service and actively poll a Task Queue for Tasks to process. When a Task Poller receives a Task, it delivers to the appropriate Executor Slot for processing. | |
| Pollers create long-polling connections to the Temporal Service and actively poll a Task Queue for Tasks to process. When a Task Poller receives a Task, it delivers to the appropriate Executor Slot for processing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Adds detail about Poller Autoscaler feature, recommends use, provides SDK snippets
Please check my formatting on the SDKtab example, not sure how this will build out :)