POC: Filter namespace data #77
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pglass
commented
May 7, 2025
| @@ -39,10 +45,27 @@ func NewAdminServiceProxyServer( | |||
| ) adminservice.AdminServiceServer { | |||
| logger = log.With(logger, common.ServiceTag(serviceName)) | |||
| clientProvider := client.NewClientProvider(clientConfig, clientFactory, logger) | |||
|
|
|||
| var remoteClientProvider client.ClientProvider | |||
There was a problem hiding this comment.
I think this is actually a "local" client provider (not remote)
pglass
commented
May 7, 2025
| } else { | ||
| // HACK: This doesn't work for mux transport. | ||
| mgr := &transport.TransportManager{} | ||
| tp, err := mgr.OpenClient(opts.Config.Inbound.Client) |
There was a problem hiding this comment.
For an outbound server, we need the client for the inbound direction. Need to pass the transport manager in here (or maybe pass in just the client itself).
davewhat
reviewed
May 7, 2025
| @@ -110,6 +110,7 @@ type ( | |||
| HealthCheck *HealthCheckConfig `yaml:"healthCheck"` | |||
| NamespaceNameTranslation NamespaceNameTranslationConfig `yaml:"namespaceNameTranslation"` | |||
| Metrics *MetricsConfig `yaml:"metrics"` | |||
| FilterNsData bool `yaml:"filterNsData"` | |||
There was a problem hiding this comment.
EnableUnsafeNsData -- My thought here is to flip the boolean around so that the default (if not configured) is that we do the filtering.
|
This looks good to me, but I'll allow @hehaifengcn to be the final approver as you guys are jamming together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
For GetNamespaceReplicationTasks,
Datain the responseDatain the response. Do GetNamespace on the destination cluster to find current value of the fieldsWhy?
Checklist
Closes
How was this tested: