Correct Preconditions error message in WorkerFactory #2693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
Hi @Quinn-With-Two-Ns |
|
Hi @phlego thank you for the contribution, please see these instructions #2686 (comment) to fix CI thanks |
|
Done @Quinn-With-Two-Ns |
The original code had `State.Initial.name()` duplicated in the error message, which was likely a copy-paste error. The fix correctly shows `State.Initial` and `State.Started` as the expected states.
Quinn-With-Two-Ns
force-pushed
the
correct-preconditions-error-message-in-workerfactory
branch
from
405ffbd to
388c3eb
Compare
Quinn-With-Two-Ns
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
This PR correct the error message for the
startmethod ofWorkerFactory.The fix correctly shows
State.InitialandState.Startedas the expected states.The PR also remove a unused variable and several unused imports.
Why?
The original code had
State.Initial.name()duplicated in the error message, which was likely a copy-paste error.Checklist
Closes
N/A
How was this tested:
N/A
Any docs updates needed?
No