Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
When the SQL persistence schema version check runs at startup (
verifyPersistenceCompatibleVersion), it now retries automatically on transientUnavailableerrors instead of failing immediately. The underlying error wrapping was also fixed to use%wso the error type is preserved through the chain and the retry predicate can actually detect it.Why?
when a node is replaced, the pod restarts before the network is fully ready. The DB might be reachable within seconds, but the one-shot startup check would fail hard and put the server into
CrashLoopBackOffrequiring a manual redeploy to recover.How did you test it?
Potential risks
The retry has no expiration (NoInterval), so if the DB is permanently unreachable, the server will block at startup indefinitely rather than crashing
#8202