Open
Conversation
a3de11e to
25cd028
Compare
stephanos
commented
Apr 10, 2026
| detailed_summary: true | ||
| check_annotations: false | ||
| annotate_only: true | ||
| skip_annotations: true |
Contributor
Author
There was a problem hiding this comment.
mikepenz/action-junit-report doesn't support showing failure details.
9091a7f to
8182970
Compare
stephanos
commented
Apr 13, 2026
| echo "::notice::Job ID for '$JOB_NAME' not visible yet (attempt $attempt/6); retrying in 5s" | ||
| sleep 5 | ||
| fi | ||
| done |
Contributor
Author
There was a problem hiding this comment.
Claude suggested doing retries here and I thought that was a good idea; wouldn't want to fail the run because of this being flaky.
38fe804 to
917d180
Compare
5ba0dd9 to
668ac8e
Compare
stephanos
commented
Apr 13, 2026
|
|
||
| // Compare against the expected output file | ||
| requireReportEquals(t, "testdata/junit-alerts-output.xml", out.Name()) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
^ moved this one up here
0fb8162 to
9e6b18d
Compare
stephanos
commented
Apr 13, 2026
| } | ||
| sb.WriteString("</td></tr>\n") | ||
| return sb.String() | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Originally this also added a link to the source code but I removed that for now to reduce scope.
stephanos
commented
Apr 13, 2026
| <testsuites tests="1" failures="1"> | ||
| <testsuite name="ALERTS" tests="1" failures="1" errors="0" id="0" time=""> | ||
| <testcase name="DATA RACE: Data race detected in TestFoo"> | ||
| <failure message="DATA RACE" type="DATA RACE"><![CDATA[WARNING: DATA RACE |
Contributor
Author
There was a problem hiding this comment.
One change I made is to standardize on type to identify whether it's a regular assertion failure or one of our "alert" types. It was in message before. Synthetic failures still set both now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Add failure details per test to GitHub summary view.
Why?
Avoid digging through logs.
How did you test it?
Example:
https://github.com/temporalio/temporal/actions/runs/24366106128?pr=9912