Open
Conversation
stephanos
force-pushed
the
stephanos/nexus-new-metrics
branch
3 times, most recently
from
ed9af24 to
1655e0e
Compare
stephanos
commented
Apr 13, 2026
| env *NexusTestEnv, | ||
| url string, | ||
| completion nexusrpc.CompleteOperationOptions, | ||
| ) (map[string][]*metricstest.CapturedRecording, error) { |
Contributor
Author
There was a problem hiding this comment.
Callers track metrics themselves now because they need to distinguish between namespace vs global
stephanos
force-pushed
the
stephanos/nexus-new-metrics
branch
2 times, most recently
from
bfc5322 to
da88682
Compare
stephanos
force-pushed
the
stephanos/nexus-new-metrics
branch
from
da88682 to
b8aaae9
Compare
stephanos
commented
Apr 14, 2026
|
|
||
| func (s *NexusWorkflowTestSuite) sendNexusCompletionRequest( | ||
| ctx context.Context, | ||
| env *NexusTestEnv, |
Contributor
Author
There was a problem hiding this comment.
Not needed anymore
stephanos
commented
Apr 14, 2026
|
|
||
| s.Run("NamespaceNotFoundNoIdentifier", func(s *NexusWorkflowTestSuite) { | ||
| env := s.newNexusWorkflowTestEnv(chasmEnabled) | ||
| env := s.newNexusWorkflowTestEnv(chasmEnabled, testcore.WithDedicatedCluster()) |
Contributor
Author
There was a problem hiding this comment.
Added wherever StartGlobalMetricCapture was used
stephanos
commented
Apr 14, 2026
| } | ||
|
|
||
| func (s *NexusAPIValidationTestSuite) TestNexusStartOperation_WithNamespaceAndTaskQueue_NamespaceNotFound() { | ||
| env := newNexusTestEnv(s.T(), false, testcore.WithDedicatedCluster()) |
Contributor
Author
There was a problem hiding this comment.
Not needed as using StartNamespaceMetricCapture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Use the new NamespaceMetricCapture etc in Nexus tests.
Why?
Allows to remove a few dedicated cluster options; ie run faster.
How did you test it?