-
-
Notifications
You must be signed in to change notification settings - Fork 602
feat!: Upgrade AWS provider and min required Terraform version to 6.18 and 1.11 respectively
#525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Upgrade AWS provider and min required Terraform version to 6.18 and 1.11 respectively
#525
Conversation
…18` and `1.11` respectively
…nto single top level variable
…red_backup_window` to `null`
…`master_password_wo_version`
…te `aws_security_group_ingress_rule`/`aws_security_group_egress_rule`
17cca40 to
696f58f
Compare
antonbabenko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have anything to add.
@magreenbaum Thank you for helping with the review!
449d8c6 to
42cb1ad
Compare
| } | ||
|
|
||
| # aurora limitless clusters do not support managed master user password | ||
| manage_master_user_password = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to keep this since manage_master_user_password defaults to true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch - added in ee41836
| cluster_instance_class = "db.r8g.large" | ||
| instances = { for i in range(2) : i => {} } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cluster_instance_class sets db_cluster_instance_class which is only for non-aurora multi-az rds clusters and seems to cause errors if using with aurora: hashicorp/terraform-provider-aws#30596 (comment)
| cluster_instance_class = "db.r8g.large" | |
| instances = { for i in range(2) : i => {} } | |
| instances = { for i in range(2) : i => { instance_class = "db.r8g.large"} } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, good to know! we are overloading the use of cluster_instance_class similar to the cluster monitoring and performance insights variables. however, we can guard against the use of setting db_cluster_instance_class on the cluster when the cluster is not intended to be an RDS mult-az cluster ee41836
| cluster_instance_class = "db.r8g.large" | ||
| instances = { for i in range(2) : i => {} } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe we should keep the instance_class var 🤔
| cluster_instance_class = "db.r8g.large" | |
| instances = { for i in range(2) : i => {} } | |
| cluster_instance_class = "db.r8g.large" | |
| instances = { for i in range(2) : i => { instance_class = "db.r8g.large"} } |
| } | ||
|
|
||
| instance_class = "db.serverless" | ||
| cluster_instance_class = "db.serverless" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar here in this file
examples/serverless/main.tf
Outdated
|
|
||
| name = "${local.name}-postgresql" | ||
| engine = "aurora-postgresql" | ||
| engine_mode = "serverless" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
serverless v1 is no longer supported / able to be created: https://repost.aws/questions/QUhcMVoChXRm2HLi8F-yih1g/announcement-support-for-aurora-serverless-v1-ending-soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed in ee41836
Co-authored-by: Melissa Greenbaum <[email protected]>
magreenbaum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!!
antonbabenko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff!
## [10.0.0](v9.16.1...v10.0.0) (2025-11-15) ### ⚠ BREAKING CHANGES * Upgrade AWS provider and min required Terraform version to `6.18` and `1.11` respectively (#525) ### Features * Upgrade AWS provider and min required Terraform version to `6.18` and `1.11` respectively ([#525](#525)) ([2bf4622](2bf4622))
|
This PR is included in version 10.0.0 🎉 |
Description
List of backwards incompatible changes
v1.11is now minimum supported version to support write-only (wo_*) attributes.v6.18is now minimum supported versionaws_security_group_ruleresources has been replaced withaws_vpc_security_group_ingress_ruleandaws_vpc_security_group_egress_ruleto allow for more flexibility in defining security group rules.master_passwordis no longer supported and only the write-only equivalent is supported (master_password_woandmaster_password_wo_version) (#513)security_group_ruleshas been split intosecurity_group_ingress_rulesandsecurity_group_egress_rulesto better match the AWS API and allow for more flexibility in defining security group rulesAdditional changes
Added
regionargument to specify the AWS region for the resources created if different from the provider region.Modified
anytypecopy_tags_to_snapshotdefault value is nowtrue(#521)db_cluster_parameter_group_parameterswas previously of typelist(map(...)), now of typemap(object(...))withnamebeing optional and defaulting to the map key if not providedpreferred_maintenance_windowandpreferred_backup_windowdefault values are nownull(#524)Removed
Variable and output changes
Removed variables:
auto_minor_version_upgrade-> still available within theinstancesvariable definitionca_cert_identifier-> available within theinstancesvariable definitionmonitoring_interval-> still available within theinstancesvariable definitionperformance_insights_enabled-> still available within theinstancesvariable definitionperformance_insights_kms_key_id-> still available within theinstancesvariable definitionperformance_insights_retention_period-> still available within theinstancesvariable definitioniam_role_managed_policy_arns-> deprecated argument onaws_iam_roleresourceiam_role_force_detach_policies-> hardcode totrueRenamed variables:
instance_class->cluster_instance_classdb_cluster_db_instance_parameter_group_name->cluster_db_instance_parameter_group_namerole_associationswas previouslyiam_rolesmaster_passwordreplaced withmaster_password_woandmaster_password_wo_versionshard_groupvariable:create_shard_groupremoved - setshard_grouptonullto disable or provide an object to enablecompute_redundancy->shard_group.compute_redundancydb_shard_group_identifier->shard_group.identifiermax_acu->shard_group.max_acumin_acu->shard_group.min_acupublicly_accessible->shard_group.publicly_accessibleshard_group_tags->shard_group.tagsshard_group_timeouts->shard_group.timeoutscluster_activity_streamvariable:create_db_cluster_activity_streamremoved - setcluster_activity_streamtonullto disable or provide an object to enabledb_cluster_activity_stream_mode->cluster_activity_stream.modedb_cluster_activity_stream_kms_key_id->cluster_activity_stream.kms_key_idengine_native_audit_fields_included->cluster_activity_stream.include_audit_fieldscluster_parameter_groupvariable:create_db_cluster_parameter_groupremoved - setcluster_parameter_grouptonullto disable or provide an object to enabledb_cluster_parameter_group_name->cluster_parameter_group.namedb_cluster_parameter_group_use_name_prefix->cluster_parameter_group.use_name_prefixdb_cluster_parameter_group_description->cluster_parameter_group.descriptiondb_cluster_parameter_group_family->cluster_parameter_group.familydb_cluster_parameter_group_parameters->cluster_parameter_group.parametersdb_parameter_groupvariable:create_db_parameter_groupremoved - setdb_parameter_grouptonullto disable or provide an object to enabledb_parameter_group_name->db_parameter_group.namecluster_parameter_group_namehas been retained for when users want to provide an existing cluster parameter group name.db_parameter_group_use_name_prefix->db_parameter_group.use_name_prefixdb_parameter_group_description->db_parameter_group.descriptiondb_parameter_group_family->db_parameter_group.familydb_parameter_group_parameters->db_parameter_group.parametersAdded variables:
regionMotivation and Context
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request