Skip to content

Conversation

@philoj
Copy link
Contributor

@philoj philoj commented Apr 9, 2025

The psc_config dynamic block in resource google_sql_database_instance.replicas keeps getting removed by the planner while the defaults are always present.
This pull request keeps the block with default values when PSC is disabled inside the replica.
No functional changes. Keeps the plan tidy, that's all

Screenshot 2025-04-09 at 11 57 53 AM

@philoj philoj requested review from a team, ayushmjain, imrannayer and q2w as code owners April 9, 2025 06:26
@google-cla
Copy link

google-cla bot commented Apr 9, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@imrannayer
Copy link
Collaborator

@philoj this is provider issue. Provider should be able to ignore permadiff for nulls. We can put this workaround in module for the time being.

@imrannayer
Copy link
Collaborator

/gcbrun

@philoj
Copy link
Contributor Author

philoj commented Apr 9, 2025

@philoj this is provider issue. Provider should be able to ignore permadiff for nulls. We can put this workaround in module for the time being.

Didn't know that 🙂. Thank you

@imrannayer imrannayer self-assigned this Apr 9, 2025
@imrannayer imrannayer merged commit 923b770 into terraform-google-modules:main Apr 9, 2025
4 checks passed
@sofuture
Copy link
Contributor

This change seemed to cause a permadiff for those fields, for my configuration at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants