feat: Backup configuration location for mssql #775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joovalst
requested review from
a team,
ayushmjain,
imrannayer and
q2w
as code owners
Collaborator
|
/gcbrun |
Collaborator
|
@joovalst can u plz resolve lint issues? Follow contribution guide |
Contributor
Author
|
@imrannayer should be resolved now |
joovalst
changed the title
Contributor
Author
|
@imrannayer can you please review |
Collaborator
|
/gcbrun |
1 similar comment
Collaborator
|
/gcbrun |
Collaborator
|
/gcbrun |
imrannayer
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mssql module doesn't currently allow setting a custom backup-location, it only supports using the default backup location. The
google_sql_database_instancesupports alocationvalue inside thebackup_configurationsettings.This configuration already exists in the PostgreSQL module, see #126.