Skip to content

fix: Add min max validations #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 30, 2025
Merged

fix: Add min max validations #776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b7390dc
Add min max validations
amrkk123 Sep 25, 2025
f424390
fixing postgres metadata.display.yaml
amrkk123 Sep 30, 2025
348f329
adding back retention unit
amrkk123 Sep 30, 2025
fbfda3d
Removing whitespace
amrkk123 Sep 30, 2025
bf2b6a9
Remove whitespace
amrkk123 Sep 30, 2025
4285b46
removing whitespace
amrkk123 Sep 30, 2025
55536e2
Remove whitespace in mysql
amrkk123 Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions modules/mysql/metadata.display.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,11 @@ spec:
enabled: true
binary_log_enabled: true
properties:
transaction_log_retention_days:
name: transaction_log_retention_days
title: Transaction Log Retention Days
min: 1
max: 35
retention_unit:
name: retention_unit
title: Retention Unit
Expand Down Expand Up @@ -209,6 +214,7 @@ spec:
name: disk_size
title: Disk Size
level: 1
min: 10
disk_type:
name: disk_type
title: Disk Type
Expand Down Expand Up @@ -283,6 +289,17 @@ spec:
insights_config:
name: insights_config
title: Insights Config
properties:
query_plans_per_minute:
name: query_plans_per_minute
title: Query Plans Per Minute
min: 0
max: 20
query_string_length:
name: query_string_length
title: Query String Length
min: 256
max: 4500
instance_type:
name: instance_type
title: Instance Type
Expand Down Expand Up @@ -328,9 +345,13 @@ spec:
maintenance_window_day:
name: maintenance_window_day
title: Maintenance Window Day
min: 1
max: 7
maintenance_window_hour:
name: maintenance_window_hour
title: Maintenance Window Hour
min: 0
max: 23
maintenance_window_update_track:
name: maintenance_window_update_track
title: Maintenance Window Update Track
Expand Down Expand Up @@ -376,6 +397,12 @@ spec:
title: Read Replica Name
regexValidation: ^[a-z][a-z0-9-]{0,95}[a-z0-9]$
validation: Read replica names must be between 1 and 97 characters long, start with a lowercase letter, and end with a lowercase letter or number. Read replica names can only contain lowercase letters, numbers, and hyphens.
disk_autoresize_limit:
name: disk_autoresize_limit
title: Disk Autoresize Limit
disk_size:
name: disk_size
title: Disk Size
edition:
name: edition
title: Edition
Expand All @@ -400,6 +427,23 @@ spec:
value: PD_SSD
- label: PD_HDD
value: PD_HDD
backup_configuration:
name: backup_configuration
title: Backup Configuration
insights_config:
name: insights_config
title: Insights Config
properties:
query_plans_per_minute:
name: query_plans_per_minute
title: Query Plans Per Minute
min: 0
max: 20
query_string_length:
name: query_string_length
title: Query String Length
min: 256
max: 4500
ip_configuration:
name: ip_configuration
title: Ip Configuration
Expand Down
42 changes: 36 additions & 6 deletions modules/postgresql/metadata.display.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ spec:
name: disk_size
title: Disk Size
level: 1
min: 10
disk_type:
name: disk_type
title: Disk Type
Expand Down Expand Up @@ -253,6 +254,17 @@ spec:
insights_config:
name: insights_config
title: Insights Config
properties:
query_plans_per_minute:
name: query_plans_per_minute
title: Query Plans Per Minute
min: 0
max: 20
query_string_length:
name: query_string_length
title: Query String Length
min: 256
max: 4500
instance_type:
name: instance_type
title: Instance Type
Expand Down Expand Up @@ -297,9 +309,13 @@ spec:
maintenance_window_day:
name: maintenance_window_day
title: Maintenance Window Day
min: 1
max: 7
maintenance_window_hour:
name: maintenance_window_hour
title: Maintenance Window Hour
min: 0
max: 23
maintenance_window_update_track:
name: maintenance_window_update_track
title: Maintenance Window Update Track
Expand Down Expand Up @@ -369,6 +385,20 @@ spec:
value: PD_SSD
- label: PD_HDD
value: PD_HDD
insights_config:
name: insights_config
title: Insights Config
properties:
query_plans_per_minute:
name: query_plans_per_minute
title: Query Plans Per Minute
min: 0
max: 20
query_string_length:
name: query_string_length
title: Query String Length
min: 256
max: 4500
ip_configuration:
name: ip_configuration
title: Ip Configuration
Expand All @@ -382,12 +412,12 @@ spec:
name: ssl_mode
title: Ssl Mode
enumValueLabels:
- label: ALLOW_UNENCRYPTED_AND_ENCRYPTED
value: ALLOW_UNENCRYPTED_AND_ENCRYPTED
- label: ENCRYPTED_ONLY
value: ENCRYPTED_ONLY
- label: TRUSTED_CLIENT_CERTIFICATE_REQUIRED
value: TRUSTED_CLIENT_CERTIFICATE_REQUIRED
- label: ALLOW_UNENCRYPTED_AND_ENCRYPTED
value: ALLOW_UNENCRYPTED_AND_ENCRYPTED
- label: ENCRYPTED_ONLY
value: ENCRYPTED_ONLY
- label: TRUSTED_CLIENT_CERTIFICATE_REQUIRED
value: TRUSTED_CLIENT_CERTIFICATE_REQUIRED
region:
name: region
title: Region
Expand Down