Skip to content

fix: add missing Authorization Delegator role to s2s auth policy #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 3, 2025
Merged

fix: add missing Authorization Delegator role to s2s auth policy #554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03ad984
fix: add missing Authorization Delegator role to s2s auth policy
ocofaigh Oct 28, 2025
4d1f446
SKIP UPGRADE TEST
ocofaigh Oct 28, 2025
bbf1864
Merge branch 'main' into delegate
ocofaigh Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ resource "ibm_iam_authorization_policy" "kms_policy" {
count = local.create_kms_auth_policy
source_service_name = "databases-for-elasticsearch"
source_resource_group_id = var.resource_group_id
roles = ["Reader"]
roles = ["Reader", "Authorization Delegator"] # Authorization Delegator role required for backup encryption key
description = "Allow all Elasticsearch instances in the resource group ${var.resource_group_id} to read the ${local.kms_service} key ${local.kms_key_id} from the instance GUID ${local.kms_key_instance_guid}"
resource_attributes {
name = "serviceName"
Expand Down Expand Up @@ -112,7 +112,7 @@ resource "ibm_iam_authorization_policy" "backup_kms_policy" {
count = local.create_backup_kms_auth_policy
source_service_name = "databases-for-elasticsearch"
source_resource_group_id = var.resource_group_id
roles = ["Reader"]
roles = ["Reader", "Authorization Delegator"] # Authorization Delegator role required for backup encryption key
description = "Allow all Elasticsearch instances in the Resource Group ${var.resource_group_id} to read the ${local.backup_kms_service} key ${local.backup_kms_key_id} from the instance GUID ${local.backup_kms_key_instance_guid}"
resource_attributes {
name = "serviceName"
Expand Down
4 changes: 2 additions & 2 deletions solutions/fully-configurable/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ resource "ibm_iam_authorization_policy" "kms_policy" {
source_service_account = local.account_id
source_service_name = "databases-for-elasticsearch"
source_resource_group_id = module.resource_group.resource_group_id
roles = ["Reader"]
roles = ["Reader", "Authorization Delegator"] # Authorization Delegator role required for backup encryption key
Copy link
Contributor

@shemau shemau Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the backup key.

description = "Allow all Elasticsearch instances in the resource group ${module.resource_group.resource_group_id} in the account ${local.account_id} to read the ${local.kms_service} key ${local.kms_key_id} from the instance GUID ${local.kms_instance_guid}"
resource_attributes {
name = "serviceName"
Expand Down Expand Up @@ -168,7 +168,7 @@ resource "ibm_iam_authorization_policy" "backup_kms_policy" {
source_service_account = local.account_id
source_service_name = "databases-for-elasticsearch"
source_resource_group_id = module.resource_group.resource_group_id
roles = ["Reader"]
roles = ["Reader", "Authorization Delegator"] # Authorization Delegator role required for backup encryption key
description = "Allow all Elasticsearch instances in the resource group ${module.resource_group.resource_group_id} in the account ${local.account_id} to read the ${local.backup_kms_service} key ${local.backup_kms_key_id} from the instance GUID ${local.backup_kms_instance_guid}"
resource_attributes {
name = "serviceName"
Expand Down