Skip to content

fix(run,script-run): user-supplied relative cmdpath not built for stack dir. #2144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix(run,script-run): user-supplied relative cmdpath not built for stack dir. #2144

wants to merge 2 commits into from
+73 −6

Conversation

@i4ki
Copy link
Contributor

@i4ki i4ki commented Apr 24, 2025

What this PR does / why we need it:

If the user-supplied command to either run or script run is a relative path then the absolute path is not being built for the stack directory that it will run on.

Issue reported by Atha Kouroussis in Discord: https://discord.com/channels/1088753599951151154/1088769572305383484/1365061925309911190

Which issue(s) this PR fixes:

none

Special notes for your reviewer:

Does this PR introduce a user-facing change?

yes, fixes a run/script-run issue.

@i4ki i4ki requested a review from a team as a code owner April 24, 2025 22:44
@github-actions
Copy link

github-actions bot commented Apr 24, 2025 •
edited
Loading 

toolsetPath: /tmp/cmd-terramate-test-1767055727
=== RUN   TestInteropCloudSyncPreview
=== RUN   TestInteropCloudSyncPreview/preview:_basic-drift
    interoperability_test.go:47: using GITHUB_EVENT_FILE=/home/runner/work/_temp/_github_workflow/event.json
=== RUN   TestInteropCloudSyncPreview/preview:_basic-drift-uppercase-id
    interoperability_test.go:47: using GITHUB_EVENT_FILE=/home/runner/work/_temp/_github_workflow/event.json
    interoperability_test.go:58: "run --quiet --sync-preview --terraform-plan-file=out.plan --target interop-tests -- terraform plan -out=out.plan --detailed-exitcode" stderr="Warning: unable to create preview: missing review request information
        > --sync-preview can only be used when GITHUB_TOKEN or GITLAB_TOKEN is exported and Terramate runs in a CI/CD environment triggered by a Pull/Merge Request event
        Warning: disabling the cloud features
        > unprocessable cloud feature
        " does not match regex "Preview created"
--- FAIL: TestInteropCloudSyncPreview (12.76s)
    --- PASS: TestInteropCloudSyncPreview/preview:_basic-drift (7.12s)
    --- FAIL: TestInteropCloudSyncPreview/preview:_basic-drift-uppercase-id (5.65s)
=== RUN   TestInteropSyncDeployment
=== RUN   TestInteropSyncDeployment/deployment:_empty
=== RUN   TestInteropSyncDeployment/deployment:_empty-uppercase-id
--- PASS: TestInteropSyncDeployment (46.88s)
    --- PASS: TestInteropSyncDeployment/deployment:_empty (23.67s)
    --- PASS: TestInteropSyncDeployment/deployment:_empty-uppercase-id (23.21s)
=== RUN   TestInteropDrift
=== RUN   TestInteropDrift/drift:_basic-drift
=== RUN   TestInteropDrift/drift:_basic-drift-uppercase-id
--- PASS: TestInteropDrift (76.72s)
    --- PASS: TestInteropDrift/drift:_basic-drift (38.25s)
    --- PASS: TestInteropDrift/drift:_basic-drift-uppercase-id (38.48s)
FAIL
FAIL	github.com/terramate-io/terramate/e2etests/cloud/interop	194.280s
FAIL

@github-actions
Copy link

github-actions bot commented Apr 24, 2025 •
edited
Loading

Preview of ubuntu/go tests in 08d2798

🔍 View Details on Terramate Cloud

.
cloudsync
engine
run
test/sandbox
e2etests/core

@github-actions
Copy link

github-actions bot commented Apr 24, 2025 •
edited
Loading

Preview of macos-ventura/go tests in 08d2798

🔍 View Details on Terramate Cloud

.
cloudsync
engine
run
test/sandbox
e2etests/core

@github-actions
Copy link

github-actions bot commented Apr 24, 2025 •
edited
Loading 

metric: time/op
ChangeDetection-4: old 4.05ms ± 5%: new 3.98ms ± 4%: delta: 0.00%
ChangeDetectionTFAndTG-4: old 3.79ms ± 5%: new 3.84ms ± 5%: delta: 0.00%
CloudReadLines-4: old 1.19ms ± 5%: new 1.15ms ± 6%: delta: -3.38%
CloudReadLine-4: old 6.76ms ± 3%: new 6.86ms ± 2%: delta: 1.47%
ListFiles-4: old 85.6µs ± 1%: new 85.4µs ± 1%: delta: 0.00%
Generate-4: old 1.53s ± 2%: new 1.55s ± 3%: delta: 1.51%
GenerateRegex-4: old 1.05s ± 3%: new 1.07s ± 4%: delta: 1.89%
TokensForExpressionComplex-4: old 1.26ms ± 2%: new 1.26ms ± 1%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 705ns ± 1%: new 705ns ± 1%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 20.4µs ± 2%: new 20.5µs ± 1%: delta: 0.74%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 1.46ms ± 1%: new 1.46ms ± 1%: delta: 0.55%
TokensForExpression-4: old 1.26ms ± 1%: new 1.26ms ± 1%: delta: 0.00%
PartialEvalComplex-4: old 552µs ± 2%: new 547µs ± 1%: delta: -0.76%
PartialEvalSmallString-4: old 4.08µs ± 2%: new 3.99µs ± 1%: delta: -2.17%
PartialEvalHugeString-4: old 2.07ms ± 1%: new 2.07ms ± 0%: delta: -0.16%
PartialEvalHugeInterpolatedString-4: old 5.09ms ± 2%: new 5.08ms ± 1%: delta: 0.00%
PartialEvalObject-4: old 27.1µs ± 2%: new 27.4µs ± 4%: delta: 0.00%
TmAllTrueLiteralList-4: old 624µs ± 2%: new 621µs ± 1%: delta: -0.57%
TmAllTrueFuncall-4: old 19.1µs ± 1%: new 19.2µs ± 3%: delta: 0.00%
TmAnyTrueLiteralList-4: old 4.73ms ± 1%: new 4.73ms ± 1%: delta: 0.00%
TmAnyTrueFuncall-4: old 19.5µs ± 1%: new 19.5µs ± 2%: delta: 0.00%
TmTernary-4: old 2.31µs ± 1%: new 2.31µs ± 3%: delta: 0.00%
TmTryUnknownFunc-4: old 2.09µs ± 1%: new 2.12µs ± 2%: delta: 1.41%
TmTryUnknownVariable-4: old 2.00µs ± 1%: new 2.04µs ± 4%: delta: 1.90%
TmTryUnknownObjectKey-4: old 2.33µs ± 1%: new 2.34µs ± 1%: delta: 0.00%
metric: alloc/op
ChangeDetection-4: old 358kB ± 0%: new 358kB ± 0%: delta: 0.00%
ChangeDetectionTFAndTG-4: old 247kB ± 0%: new 247kB ± 1%: delta: 0.00%
CloudReadLines-4: old 3.12MB ± 0%: new 3.12MB ± 0%: delta: 0.00%
CloudReadLine-4: old 3.37MB ± 0%: new 3.37MB ± 0%: delta: 0.00%
ListFiles-4: old 27.6kB ± 0%: new 27.6kB ± 0%: delta: 0.00%
Generate-4: old 2.23GB ± 0%: new 2.23GB ± 0%: delta: 0.00%
GenerateRegex-4: old 926MB ± 0%: new 926MB ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 394kB ± 0%: new 394kB ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 512B ± 0%: new 512B ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 12.5kB ± 0%: new 12.5kB ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 395kB ± 0%: new 395kB ± 0%: delta: 0.00%
TokensForExpression-4: old 394kB ± 0%: new 394kB ± 0%: delta: 0.00%
PartialEvalComplex-4: old 361kB ± 0%: new 361kB ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 1.95kB ± 0%: new 1.95kB ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 196kB ± 0%: new 196kB ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 4.31MB ± 0%: new 4.31MB ± 0%: delta: 0.00%
PartialEvalObject-4: old 19.4kB ± 0%: new 19.4kB ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 321kB ± 0%: new 321kB ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 10.6kB ± 0%: new 10.6kB ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 2.09MB ± 0%: new 2.09MB ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 10.7kB ± 0%: new 10.7kB ± 0%: delta: 0.00%
TmTernary-4: old 1.18kB ± 0%: new 1.18kB ± 0%: delta: 0.00%
TmTryUnknownFunc-4: old 784B ± 0%: new 784B ± 0%: delta: 0.00%
TmTryUnknownVariable-4: old 768B ± 0%: new 768B ± 0%: delta: 0.00%
TmTryUnknownObjectKey-4: old 952B ± 0%: new 952B ± 0%: delta: 0.00%
metric: allocs/op
ChangeDetection-4: old 2.48k ± 0%: new 2.48k ± 0%: delta: 0.00%
ChangeDetectionTFAndTG-4: old 1.56k ± 0%: new 1.56k ± 1%: delta: 0.00%
CloudReadLines-4: old 5.54k ± 0%: new 5.54k ± 0%: delta: 0.00%
CloudReadLine-4: old 60.0k ± 0%: new 60.0k ± 0%: delta: 0.00%
ListFiles-4: old 335 ± 0%: new 335 ± 0%: delta: 0.00%
Generate-4: old 25.7M ± 0%: new 25.7M ± 0%: delta: 0.00%
GenerateRegex-4: old 18.4M ± 0%: new 18.4M ± 0%: delta: 0.00%
TokensForExpressionComplex-4: old 4.83k ± 0%: new 4.83k ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 20.0 ± 0%: new 20.0 ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 227 ± 0%: new 227 ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 3.19k ± 0%: new 3.19k ± 0%: delta: 0.00%
TokensForExpression-4: old 4.83k ± 0%: new 4.83k ± 0%: delta: 0.00%
PartialEvalComplex-4: old 3.78k ± 0%: new 3.78k ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 26.0 ± 0%: new 26.0 ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 38.0 ± 0%: new 38.0 ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 26.1k ± 0%: new 26.1k ± 0%: delta: 0.00%
PartialEvalObject-4: old 183 ± 0%: new 183 ± 0%: delta: 0.00%
TmAllTrueLiteralList-4: old 5.94k ± 0%: new 5.94k ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 275 ± 0%: new 275 ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 59.6k ± 0%: new 59.6k ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 277 ± 0%: new 277 ± 0%: delta: 0.00%
TmTernary-4: old 27.0 ± 0%: new 27.0 ± 0%: delta: 0.00%
TmTryUnknownFunc-4: old 21.0 ± 0%: new 21.0 ± 0%: delta: 0.00%
TmTryUnknownVariable-4: old 20.0 ± 0%: new 20.0 ± 0%: delta: 0.00%
TmTryUnknownObjectKey-4: old 23.0 ± 0%: new 23.0 ± 0%: delta: 0.00%

sixstone-qq
sixstone-qq previously approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@sixstone-qq sixstone-qq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from i4k-bump-dev4 to main April 25, 2025 09:56
@snakster snakster dismissed sixstone-qq’s stale review April 25, 2025 09:56

The base branch was changed.

@mcalhoun mcalhoun changed the title fix(run,script-run): user-supplied relative cmdpath not built for sta… t Oct 30, 2025
@mcalhoun
Copy link
Contributor

Closing as stale

@mcalhoun mcalhoun closed this Oct 30, 2025
@snakster snakster changed the title t fix(run,script-run): user-supplied relative cmdpath not built for stack dir. Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sixstone-qq sixstone-qq sixstone-qq left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@i4ki @mcalhoun @sixstone-qq