-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Opossum vulnerability #2838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Opossum vulnerability #2838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2833 This does a check for the opossum vulnerability, see https://opossum-attack.com/. Currently it uses wget or curl, so one if them has to be present. Proxy handling was introduced in check_pwnedkeys() which should help that function too. Also timeouts were used for curl and wget for better maturity. Todos: - handling when neither curl or wget is present - at least a warning when no HTTP service is present - take care of the diffs in http_get_header() to make this work --> make sure it still does using check_pwnedkeys() - -H ''? - ret codes - backport proxy stuff in http_get_header() to 3.2 - backport curl/wget timeouts to 3.2 - manpage (incl. RFC 2817)
text + html , comp_ok --> ok
text + html , 2nd comp_ok --> ok
- use http instead of https - use URI of NODE - handle not HTTP services (based on what's written on https://opossum-attack.com/) - make sure it works in case where certificate-based authentication is requested on HTTP thus setting SERVICE to ""
- fix bash regex which resulted in cases with https:// in URI in a mangeld curl call - try also plain text curl test when client auth is requested via HTTPS and SERVICE is empty
... doesn't accept LFs in header - introducing http_header_printf, way easier - updates anyway to http_get
|
better to open a new PR ,see #2842 |
drwetter
added a commit
that referenced
this pull request
Jul 12, 2025
Redo PR for Opossum , see #2838
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Fixes #2833
This does a check for the opossum vulnerability, see https://opossum-attack.com/ .
It uses a separate function to send the payload and retrieve the result (
http_header_printf()). It uses no curl or wget. The latter wouldn't work anyway as according to the manpage as the HTTP header to sent must not contain LFs.This function was introduced because
http_get_header()could use wget if curl is not available. On the way to this PRhttp_get_headerwas improved, so that timeouts were used for curl and wget for better maturity.Done:
What is your pull request about?
If it's a code change please check the boxes which are applicable
help()