chore: Node.js maintenance update #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update package.json to use pnpm as package manager - Convert yarn.lock to pnpm-lock.yaml - Update GitHub Actions to use pnpm instead of yarn
- Downgrade textlint-rule-helper to 2.2.4 for compatibility - Add pnpm overrides to ensure consistent @textlint package versions - Fix Document:exit return type to return Promise<void> instead of Promise<void[]> - Keep textlint packages at v12 for compatibility with textlint-rule-helper
- Replace httpstat.us with tools-httpstatus.pickup-services.com for status code tests - Skip tests that depend on completely external services (npm, consul.io, jenkins, mysql) - Skip redirect tests as they fail when httpstat.us is down - Update test expectations for new URL lengths
azu
commented
Aug 16, 2025
src/no-dead-link.ts
Outdated
| }); | ||
| const linkTasks = URIs.map((item) => () => lint(item, ruleOptions.retry)); | ||
| return queue.addAll(linkTasks); | ||
| return queue.addAll(linkTasks).then(() => {}); |
Reverted the return statement to return queue.addAll(linkTasks) directly
without the .then(() => {}) wrapper as requested in PR review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Package Manager Migration: Converted from yarn v1 to pnpm
package.jsonto use pnpm as packageManageryarn.locktopnpm-lock.yamlGitHub Actions Updates:
Repository Settings:
.github/release.ymlconfigurationTest Plan
🤖 Generated with Claude Code