Skip to content

Conversation

daetcm
Copy link
Contributor

@daetcm daetcm commented Jan 28, 2025

@daetcm daetcm force-pushed the updates-for-sf6 branch 2 times, most recently from 5a843fa to a138b5b Compare January 28, 2025 16:12
@homersimpsons
Copy link
Collaborator

Thanks, @daetcm, for this huge first step.

We should go with doctrine/dbal@v4 because it is not feasible to fix the tests without introducing breaking changes inside doctrinre/dbal@v3, see doctrine/dbal#6764 (comment)

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 88.84462% with 28 lines in your changes missing coverage. Please review.

Project coverage is 97.24%. Comparing base (67e4ee7) to head (a2fb734).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
src/SchemaVersionControl/SchemaBuilder.php 79.31% 18 Missing ⚠️
src/SchemaVersionControl/SchemaNormalizer.php 94.11% 5 Missing ⚠️
...hemaVersionControl/SchemaVersionControlService.php 81.48% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #288      +/-   ##
============================================
- Coverage     97.90%   97.24%   -0.66%     
- Complexity     1380     1470      +90     
============================================
  Files            61       65       +4     
  Lines          4243     4905     +662     
============================================
+ Hits           4154     4770     +616     
- Misses           89      135      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@homersimpsons homersimpsons force-pushed the updates-for-sf6 branch 3 times, most recently from 4182c81 to 3c1b0ca Compare June 10, 2025 11:53
@homersimpsons homersimpsons merged commit af4c575 into thecodingmachine:master Jun 10, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants