Skip to content

Conversation

ajgarlag
Copy link
Contributor

@ajgarlag ajgarlag commented Mar 4, 2025

It fixes tests with lowest allowed versions

This fixes tests with lowest allowed versions
@chalasr
Copy link
Member

chalasr commented Mar 4, 2025

I was about to remove Symfony 5.4 support ^^ what do you think?

@ajgarlag
Copy link
Contributor Author

ajgarlag commented Mar 4, 2025

I'm unsure if Symfony 5.4 support should be dropped before or after tagging v1.0, but we should remove the related BC layer too.

Anyway, this PR is not related to the Symfony version, but to the league/server-bundle version.

@ajgarlag
Copy link
Contributor Author

ajgarlag commented Mar 5, 2025

See #218

@ajgarlag
Copy link
Contributor Author

@chalasr I see you have approved all my PRs except this one, but this is needed to fix the --prefer-lowest unit test job.

@chalasr
Copy link
Member

chalasr commented Mar 13, 2025

Thank you @ajgarlag.

@chalasr chalasr merged commit 7bd39e5 into thephpleague:master Mar 13, 2025
30 of 33 checks passed
@ajgarlag ajgarlag deleted the fix-prefer-lower-tests branch March 13, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants