Module api conversion of mixer, mixin mixout, and mux modules #10294
+14
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsarha
requested review from
dbaluta,
fkwasowi,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the memory management approach for mixer, mixin_mixout, and mux audio modules by converting them to use the module API for allocation and deallocation. This simplifies the code by removing manual memory management responsibilities from the components.
- Replaced manual memory allocation (
rzalloc) with module-managed allocation (mod_zalloc) - Eliminated manual cleanup code in free functions since module API handles deallocation automatically
- Updated data blob handler creation to use module API (
mod_data_blob_handler_new)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/audio/mux/mux.c | Converted to module API allocation, simplified error handling by removing cleanup paths |
| src/audio/mixin_mixout/mixin_mixout.c | Updated memory allocation to use module API for both mixin and mixout components |
| src/audio/mixer/mixer.c | Switched to module-managed memory allocation and removed manual cleanup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jsarha
force-pushed
the
module_api_mixer_mixin-mixout_mux
branch
from
fad5221 to
e999fde
Compare
singalsu
approved these changes
Oct 22, 2025
lgirdwood
approved these changes
Oct 22, 2025
|
SOFCI TEST |
|
rerun CI as no data or not run on several duts |
lyakh
approved these changes
Oct 27, 2025
added 3 commits
October 31, 2025 16:39
Allocate all memory, blob handlers, and fast_get() buffers through module API mod_alloc() and friends. Signed-off-by: Jyri Sarha <[email protected]>
Allocate all memory, blob handlers, and fast_get() buffers through module API mod_alloc() and friends. Signed-off-by: Jyri Sarha <[email protected]>
Allocate all memory, blob handlers, and fast_get() buffers through module API mod_alloc() and friends. Signed-off-by: Jyri Sarha <[email protected]>
jsarha
force-pushed
the
module_api_mixer_mixin-mixout_mux
branch
from
e999fde to
13f248f
Compare
|
These new versions of module conversions use module API to allocate the resources, but the code still has all the resource freeing code in place. |
kv2019i
approved these changes
Oct 31, 2025
softwarecki
reviewed
Oct 31, 2025
| cd->model_handler = mod_data_blob_handler_new(mod); | ||
| if (!cd->model_handler) { | ||
| comp_err(dev, "comp_data_blob_handler_new() failed."); | ||
| comp_err(dev, "mod_data_blob_handler_new() failed."); |
There was a problem hiding this comment.
module data blob handler creation failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.