Tools: Topology: Build development topology sof-ptl-rt721-4ch-allfmt #10310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: To add formats to DMIC need the kernel patch thesofproject/linux#5559 |
This patch adds option to add the float and 8-bit unsigned format to SDW jack playback and capture. The formats are added only if PCM_FORMAT_ALL is set to true. The default value in common_definitions.conf if false. Signed-off-by: Seppo Ingalsuo <[email protected]>
This patch adds option to add float and unsigned 8-bit playback formats to deep buffer if PCM_FORMAT_ALL is set to true. Signed-off-by: Seppo Ingalsuo <[email protected]>
This patch adds option to add float and unsigned 8-bit playback formats to SDW speaker if PCM_FORMAT_ALL is set to true. Signed-off-by: Seppo Ingalsuo <[email protected]>
This patch adds option to add float and unsigned 8-bit capture formats to SDW microphones if PCM_FORMAT_ALL is set to true. Signed-off-by: Seppo Ingalsuo <[email protected]>
This patch adds option to add float and unsigned 8-bit capture formats to PCH DMIC if PCM_FORMAT_ALL is set to true. Signed-off-by: Seppo Ingalsuo <[email protected]>
This patch duplicates from production topologies the PTL ALC721 topology into development directory and adds to all PCMs the FLOAT_LE and U8 formats. Signed-off-by: Seppo Ingalsuo <[email protected]>
singalsu
force-pushed
the
tplg_sdw_add_float_u8
branch
from
bdadf7b to
7ebe860
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for additional PCM audio formats (U8 and FLOAT_LE) to the Intel SoundWire topology configuration by introducing a new PCM_FORMAT_ALL build option. When enabled, the topology supports 5 audio formats instead of the default 3 (S16_LE, S24_LE, S32_LE, U8, FLOAT_LE).
- Introduces
PCM_FORMAT_ALLconfiguration option with default valuefalse - Conditionally adds U8 and FLOAT_LE format support across all relevant audio components
- Adds new development topology target
sof-ptl-rt721-4ch-allfmtwith extended format support enabled
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/topology/topology2/include/common/common_definitions.conf | Defines new PCM_FORMAT_ALL configuration option |
| tools/topology/topology2/platform/intel/sdw-jack-generic.conf | Adds conditional format support for jack audio components |
| tools/topology/topology2/platform/intel/sdw-dmic-generic.conf | Adds conditional format support for SoundWire DMIC components |
| tools/topology/topology2/platform/intel/sdw-amp-generic.conf | Adds conditional format support for SoundWire amplifier components |
| tools/topology/topology2/platform/intel/dmic-generic.conf | Adds conditional format support for generic DMIC components |
| tools/topology/topology2/platform/intel/deep-buffer.conf | Adds conditional format support for deep buffer playback |
| tools/topology/topology2/development/tplg-targets.cmake | Adds new RT721 topology target with all formats enabled |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+371
to
+380
| out_rate $JACK_RATE | ||
| out_bit_depth 32 | ||
| out_valid_bit_depth 32 | ||
| out_sample_type $SAMPLE_TYPE_FLOAT | ||
| } | ||
| { | ||
| out_rate $JACK_RATE | ||
| out_bit_depth 8 | ||
| out_valid_bit_depth 8 | ||
| out_sample_type $SAMPLE_TYPE_UNSIGNED_INTEGER |
There was a problem hiding this comment.
Inconsistent indentation: these lines have extra spaces before the values compared to other similar entries in the same block.
Suggested change
| out_rate $JACK_RATE | |
| out_bit_depth 32 | |
| out_valid_bit_depth 32 | |
| out_sample_type $SAMPLE_TYPE_FLOAT | |
| } | |
| { | |
| out_rate $JACK_RATE | |
| out_bit_depth 8 | |
| out_valid_bit_depth 8 | |
| out_sample_type $SAMPLE_TYPE_UNSIGNED_INTEGER | |
| out_rate $JACK_RATE | |
| out_bit_depth 32 | |
| out_valid_bit_depth 32 | |
| out_sample_type $SAMPLE_TYPE_FLOAT | |
| } | |
| { | |
| out_rate $JACK_RATE | |
| out_bit_depth 8 | |
| out_valid_bit_depth 8 | |
| out_sample_type $SAMPLE_TYPE_UNSIGNED_INTEGER |
Comment on lines
+371
to
+380
| out_rate $JACK_RATE | ||
| out_bit_depth 32 | ||
| out_valid_bit_depth 32 | ||
| out_sample_type $SAMPLE_TYPE_FLOAT | ||
| } | ||
| { | ||
| out_rate $JACK_RATE | ||
| out_bit_depth 8 | ||
| out_valid_bit_depth 8 | ||
| out_sample_type $SAMPLE_TYPE_UNSIGNED_INTEGER |
There was a problem hiding this comment.
Inconsistent indentation: these lines have extra spaces before the values compared to other similar entries in the same block.
Suggested change
| out_rate $JACK_RATE | |
| out_bit_depth 32 | |
| out_valid_bit_depth 32 | |
| out_sample_type $SAMPLE_TYPE_FLOAT | |
| } | |
| { | |
| out_rate $JACK_RATE | |
| out_bit_depth 8 | |
| out_valid_bit_depth 8 | |
| out_sample_type $SAMPLE_TYPE_UNSIGNED_INTEGER | |
| out_rate $JACK_RATE | |
| out_bit_depth 32 | |
| out_valid_bit_depth 32 | |
| out_sample_type $SAMPLE_TYPE_FLOAT | |
| } | |
| { | |
| out_rate $JACK_RATE | |
| out_bit_depth 8 | |
| out_valid_bit_depth 8 | |
| out_sample_type $SAMPLE_TYPE_UNSIGNED_INTEGER |
| ] | ||
| } | ||
| "false" { | ||
| num_output_audio_formats 1 |
There was a problem hiding this comment.
Removed line that sets num_output_audio_formats to 1, but this value is still needed when PCM_FORMAT_ALL is false. The conditional logic should preserve this line in the false branch.
|
@singalsu looks like some indentation update is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.