Conversation
Contributor
Author
|
Ref NEB-132 |
jakeloo
approved these changes
Apr 1, 2025
Member
jakeloo
left a comment
jakeloo
left a comment
There was a problem hiding this comment.
Can we also add CI step to run test automatically?
Contributor
Author
|
Added - we just need a way of using the dev private key |
Contributor
Author
|
Need you to add the secret defined in the CI for it to run. I can't access repo settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds pytest for insight and engine tests using thirdweb-dev api. Should I be using a dummy API instead? I wanted to ensure the API calls work correctly e.g. when we are messing around with types.
Also adds tests for adapters