Allow overriding Session ID for Guest mode#124
Merged
0xFirekeeper merged 1 commit intomainfrom Jan 17, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
=======================================
Coverage ? 76.58%
=======================================
Files ? 28
Lines ? 4804
Branches ? 665
=======================================
Hits ? 3679
Misses ? 951
Partials ? 174 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes TOOL-3133
PR-Codex overview
This PR introduces additional parameters to the
LinkAccountmethod across multiple wallet implementations, allowing for a more flexible linking process. It addsdefaultSessionIdOverrideandforceWalletIds, enhancing guest authentication and wallet linking functionalities.Detailed summary
defaultSessionIdOverrideandforceWalletIdsparameters toLinkAccountmethod in:PrivateKeyWalletSmartWalletIThirdwebWalletEcosystemWalletPreAuth_Guestto acceptdefaultSessionIdOverride.PreAuth_GuestandPreAuth_SiweExternalto use new parameters.