Add automatic image support for various archs #117
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are mixing tabs and spaces. |
|
Sorry If I'm missing something here - but doesn't go default to building on whatever arch your currently on anyway? |
|
@thomseddon you are right. Totally missed that. |
|
@SuperSandro2000 @thomseddon I think this PR would not be needed then as PR #116 already introduced. I include the PR as I was using buildx for building the images for supporting multi arch: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modification allows for automatic image support for various archs.
Added manifest file for the docker image for multi-arch support.
I have added the build to this repo which support multi-arch:
https://hub.docker.com/repository/docker/imansour/traefik-forward-auth/
Supported arch:
linux/amd64, linux/386, linux/arm64, linux/ppc64le, linux/s390x, linux/arm/v7, linux/arm/v6