Skip to content

Fix minor problems caught by valgrind #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thp merged 2 commits into from
Aug 25, 2025
+4 −2
Merged

Fix minor problems caught by valgrind #504

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27ee815
Fix uninitialized data caught by Valgrind
wmww Aug 14, 2025
584245a
Fix memory leak in psmove_connect_internal()
wmww Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/psmove.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,9 @@ psmove_connect_internal(const wchar_t *serial, const char *path, int id, unsigne
if (move->connection_type == Conn_Unknown) {
move->connection_type = Conn_USB;
}
move->serial_number = psmove_get_serial(move);
char* new_serial = psmove_get_serial(move);
free(move->serial_number);
move->serial_number = new_serial;
}

// Recently disconnected controllers might still show up in hidapi (especially Windows).
Expand Down Expand Up @@ -916,7 +918,7 @@ psmove_connect()
int
_psmove_read_btaddrs(PSMove *move, PSMove_Data_BTAddr *host, PSMove_Data_BTAddr *controller)
{
unsigned char btg[PSMOVE_MAX_BTADDR_GET_SIZE];
unsigned char btg[PSMOVE_MAX_BTADDR_GET_SIZE] = {0};
size_t report_size = PSMOVE_BTADDR_GET_SIZE;
int res;

Expand Down
Loading