UefiPayloadPkg: Setup temporary GDT for x64 UniversalPayload #11778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianocore-assign-reviewers
bot
requested review from
ChaselChiu,
Sean-StarLabs,
benjamindoron,
gdong1,
gguo11837463,
jameslu8 and
shuoliu0
AjanZhong
force-pushed
the
debug-hang
branch
from
849d84f to
8f62beb
Compare
shuoliu0-ocp
left a comment
shuoliu0-ocp
left a comment
There was a problem hiding this comment.
is this needed for non-fit boot path as well?
Contributor
Author
It should be. However, we have no validation environment for non-fit solution. Need members who are working on non-fit solution to double check whether non-fit solution has same issue. |
AjanZhong
force-pushed
the
debug-hang
branch
from
8f62beb to
ff531e0
Compare
Contributor
Author
|
@gguo11837463 @gdong1 @ChaselChiu Hi, would you mind help review this patch when you are available. Thanks. |
Separate Exception Stacks has been enabled by default in commit [1], in this case, TSS will be appended to original GDT. As secondary bootloader, UniversalPayload solution has different boot flow from original EDK2. When DxeMain tries to append TSS after original GDT, the original GDT is empty. It leads to system reboot when DxeMain tries to install new GDT which is appended with TSS. To fix this issue, set up temporary GDT with 64-bit code and data descriptors. [1] tianocore@cec2c6 Signed-off-by: Ajan Zhong <[email protected]>
Variable ChildBusAddress is not used in function ParsePciRootBridge, it triggers build error on GCC version gcc version 13.3.0. Remove this variable to fix build error. Signed-off-by: Ajan Zhong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate Exception Stacks has been enabled by default in commit [1], in this case, TSS will be appended to original GDT.
As secondary bootloader, UniversalPayload solution has different boot flow from original EDK2. When DxeMain tries to append TSS after original GDT, the original GDT is empty. It leads to system reboot when DxeMain tries to install new GDT which is appended with TSS.
To fix this issue, set up temporary GDT with 64-bit code and data descriptors.
[1] cec2c6
Description
Separate Exception Stacks has been enabled, however, in original implementation, GDT has not been enabled yet for UniversalPayload, it leads to new GDT with TSS appended is illegal format for GDT.
Add temporary GDT for UniversalPayload x64 solution to ensure separated exception stack can be enabled successfully.
How This Was Tested
Validated on UniversalPayload x64 solution on top of QEMU
Integration Instructions
N/A