[BACK-3478] Add email notifications work system processors. #896
Conversation
…sers on specific events.
| } | ||
|
|
||
| func (c *Coordinator) startTimer() { | ||
| func (c *Coordinator) tick() <-chan time.Time { |
There was a problem hiding this comment.
Were the changes in this file due to a bug? If so, what were you seeing? This implementation is much cleaner, but curious to know why the change.
There was a problem hiding this comment.
Discussed during meeting, this is mainly because as of Go 1.23, the garbage collector will properly reclaim tickers so this isn't needed anymore.
There was a problem hiding this comment.
Ah, right. Sorry, I forgot.
| @@ -0,0 +1,129 @@ | |||
| package claimaccount | |||
There was a problem hiding this comment.
In order to fit in with the other platform and work implementations, how about we move this to notifications/work/users/claim. And, for the others, notifications/work/users/connections/new and notifications/work/users/connections/issues.
| @@ -0,0 +1,93 @@ | |||
| package v1 | |||
There was a problem hiding this comment.
Rename to just notifications.go?
| return nil | ||
| } | ||
|
|
||
| type confirmationClientConfig struct { |
There was a problem hiding this comment.
[nit] Move to top (as in the auth service) or bottom so it isn't buried here?
|
|
||
| client, err := confirmationClient.NewClientWithResponses(cfg.ServiceAddress, opts) | ||
| if err != nil { | ||
| return errors.Wrap(err, "unable to create confirmations client") |
There was a problem hiding this comment.
[nit] confirmations -> confirmation (for consistency)
| return errors.Wrap(err, "unable to create confirmations client") | |
| return errors.Wrap(err, "unable to create confirmation client") |
|
|
||
| cfg := &confirmationClientConfig{} | ||
| if err := cfg.Load(); err != nil { | ||
| return errors.Wrap(err, "unable to load confirmations client config") |
There was a problem hiding this comment.
[nit] confirmations -> confirmation
| return errors.Wrap(err, "unable to load confirmations client config") | |
| return errors.Wrap(err, "unable to load confirmation client config") |
| scheduledProcessors := []work.Processor{ | ||
| claimaccount.NewProcessor(notificationDependencies), | ||
| connectaccount.NewProcessor(notificationDependencies), | ||
| connectionissues.NewProcessor(notificationDependencies), |
There was a problem hiding this comment.
[nit] scheduledProcessors -> notificationsProcessors (for consistency)
| scheduledProcessors := []work.Processor{ | |
| claimaccount.NewProcessor(notificationDependencies), | |
| connectaccount.NewProcessor(notificationDependencies), | |
| connectionissues.NewProcessor(notificationDependencies), | |
| notificationsProcessors := []work.Processor{ | |
| claimaccount.NewProcessor(notificationsDependencies), | |
| connectaccount.NewProcessor(notificationsDependencies), | |
| connectionissues.NewProcessor(notificationsDependencies), |
| "github.com/tidepool-org/platform/conditionalnotifications/connectionissues" | ||
| ) | ||
|
|
||
| func NotificationRoutes() []dataService.Route { |
There was a problem hiding this comment.
[nit] Rename to NotificationsRoutes (note the plural to match).
| func NotificationRoutes() []dataService.Route { | |
| func NotificationsRoutes() []dataService.Route { |
| routes = append(routes, SourcesRoutes()...) | ||
| routes = append(routes, SummaryRoutes()...) | ||
| routes = append(routes, AlertsRoutes()...) | ||
| routes = append(routes, NotificationRoutes()...) |
There was a problem hiding this comment.
[nit] Rename to NotificationsRoutes (note the plural to match).
| routes = append(routes, NotificationRoutes()...) | |
| routes = append(routes, NotificationsRoutes()...) |
| } | ||
|
|
||
| type Metadata struct { | ||
| ClinicId string `json:"clinicId,omitempty"` |
There was a problem hiding this comment.
[nit] In platform, usually it is ClinicID to conform with the Go common style guide. Same for other Ids. (The Golang variable name is ID, but the exported JSON is Id.)
No description provided.