Add chimney to pois

[rwrx]

Add chimney to pois

[nvkelso]

• Please also update POIs layer documentation in this PR (and the other ones).
  • https://github.com/tilezen/vector-datasource/blob/418ad3fb58ef18e5c39d22d1cdc3b88c64429914/docs/layers.md#poi-kind-values
• Since chimeny's don't usually have names, we need to add chimney to the PONI list.

  • vector-datasource/yaml/pois.yaml

    Lines 446 to 448 in 418ad3f

    	- man_made: [ adit, communications_tower, chimney, crane, mast, mineshaft, obelisk, observatory,
    	offshore_platform, petroleum_well, power_wind, telescope, water_tower,
    	water_well, watermill, windmill ]

• Vary min_zoom, like obelisk
• Add tests

See also:

• https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dchimney

[nvkelso]

These and the other PRs need to have tests added.

[rwrx]

I have added chimney to docs. I would also create some tests but from looking into actual tests I am not sure how to do this. For example this is one chimney: https://www.openstreetmap.org/way/264214092.

[nvkelso]

Please vary the min_zoom, like with like for obelisk:

  - filter: {man_made: obelisk}
    min_zoom:
      lookup:
        key: { call: { func: mz_to_float_meters, args: [ { col: height } ] } }
        op: '>='
        table:
          - [ 14, 20 ]  # z14 if height >= 20m
          - [ 15, 10 ]  # z15 if height >= 10m
        default: 16

[rwrx]

Ok, I have changed it as is in Obelisk.

[nvkelso]

For a test, try out:

• https://github.com/tilezen/vector-datasource/blob/master/integration-test/2020-locality-osm-ne-join.py
• https://github.com/tilezen/vector-datasource/blob/master/integration-test/1082-common.py

[rwrx]

@nvkelso I am not sure about the tests you mentioned. Should I copy these tests you mentioned? Thank you.